Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remove-members helper script #2458

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Add remove-members helper script #2458

merged 1 commit into from
Mar 10, 2021

Conversation

mrbobbytables
Copy link
Member

This was originally opened in PR #2048 where it was desired that this script be replaced with a go version. Issue #2052 was created with that purpose, but hasn't been moved on yet. It's probably better that this get merged for now instead of living only on my local system. 😬

It can be removed once the tool is written.

/cc @nikhita

@k8s-ci-robot k8s-ci-robot requested a review from nikhita January 24, 2021 17:48
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 24, 2021
nikhita
nikhita approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold
in case @cblecker has comments

/assign @cblecker

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 25, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2021
spiffxp
spiffxp suggested changes Jan 28, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totes happy to merge and iterate away from bash, but would like some usage instructions

hack/remove-members.sh Show resolved Hide resolved
Base automatically changed from master to main January 29, 2021 19:38
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2021
@mrbobbytables mrbobbytables mentioned this pull request Feb 28, 2021
Open
spiffxp
spiffxp approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/hold cancel
merge and iterate

I would rather not have @mrbobbytables feel like they have to be the one to run this not-checked-in script next time we want to remove members

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables, nikhita, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mrbobbytables,nikhita,spiffxp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 08ea690 into kubernetes:main Mar 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 10, 2021
@mrbobbytables mrbobbytables deleted the add-script branch August 16, 2021 11:51
@blaisep
Copy link

blaisep commented Mar 8, 2023

Over in #2052 there's a request to implement this in a proper programming language and I wanted to offer to adapt a github action that some of us built over in:
https://github.com/cucumber/action-retire-inactive-contributors/actions/runs/4361276398/jobs/7625018582

The description of the features is in:
https://github.com/cucumber/action-retire-inactive-contributors/tree/main/features

and a general diagram is at:
https://github.com/cucumber/action-retire-inactive-contributors#now-as-a-github-action

@ryjones
Copy link

ryjones commented Mar 8, 2023

@blaisep - over at Hyperledger, we're casting about for tooling like this. Shoot me an email?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita approved these changes

@spiffxp spiffxp spiffxp approved these changes

Assignees

@spiffxp spiffxp

@cblecker cblecker

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
7 participants
@mrbobbytables @k8s-ci-robot @blaisep @ryjones @spiffxp @nikhita @cblecker